fix: gratuity calculation for 'Sum of all previous slabs' option #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs tests |
|
@AyshaHakeem Hope this will resolve soon. |
…s with experience matching the upper limit of a slab
nabinhait
requested changes
Jan 2, 2025
| slab_found = True | ||
|
|
||
| elif self._is_experience_within_slab(slab, experience): | ||
| gratuity_amount += ( | ||
| years_left * total_component_amount * slab.fraction_of_applicable_earnings | ||
| ) | ||
| slab_found = True | ||
| years_left -= slab.to_year - slab.from_year |
There was a problem hiding this comment.
The years_left calculation does not seem correct. In the case of _is_experience_within_slab, you should directly set years_left = 0.
AyshaHakeem
requested review from
nabinhait
and removed request for
ruchamahabal
nabinhait
approved these changes
Jan 21, 2025
nabinhait
added a commit
that referenced
this pull request
Jan 21, 2025
…2471 fix: gratuity calculation for 'Sum of all previous slabs' option (backport #2471)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Employees with experience matching the upper limit of a slab are now correctly applied the appropriate Gratuity Rule Slab for Gratuity calculation.
Example:
For an Employee with exactly 5 years of experience and the following Gratuity Rule Slabs:
0-5 years: Fraction = 0.7
5-0 years: Fraction = 1.0
The calculation incorrectly placed the employee in the second slab due to the condition in
_is_experience_within_slab. This caused an amount higher than the correct gratuity amount to be calculated.Also, the
years_leftcalculation was only updated within the if_is_experience_beyond_slabblock.